Repository navigation
Avoid ResourceWarning with io.fits tests - #8439
Merged
Merged
Conversation
The warning that was printed at the end of pytest run:
sys:1: ResourceWarning: unclosed file <_io.BufferedWriter name=6>
comes from `test_write_hdulist_to_stream` and is because of the use of
a subprocess with a pipe that was not closed. See
https://mail.python.org/pipermail/python-dev/2016-August/145830.html
Codecov Report
@@ Coverage Diff @@
## master #8439 +/- ##
==========================================
- Coverage 86.78% 86.78% -0.01%
==========================================
Files 387 387
Lines 58123 58123
Branches 1060 1060
==========================================
- Hits 50441 50440 -1
- Misses 7067 7068 +1
Partials 615 615
Continue to review full report at Codecov.
|
pllim
approved these changes
Feb 21, 2019
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
💯 Yes, thank you!!! Good investigation, @saimn !
I can confirmed that the warnings was in master (https://travis-ci.org/astropy/astropy/jobs/496503903) but not in this PR (https://travis-ci.org/astropy/astropy/jobs/496246469) for the same job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning that was printed at the end of pytest run:
comes from
test_write_hdulist_to_streamand is because of the use of a subprocess with a pipe that was not closed. See https://mail.python.org/pipermail/python-dev/2016-August/145830.htmlRef #7913 (can be closed ?)
Probably doesn't need to be backported ? Using Popen as a context manager seems to be possible since Python 3.2