Repository navigation
Update expat to 2.2.6 - #8343
Conversation
|
CIs are failing. |
pllim
added
external
Codecov Report
@@ Coverage Diff @@
## master #8343 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 388 388
Lines 58101 58101
Branches 1060 1060
=======================================
Hits 50405 50405
Misses 7081 7081
Partials 615 615Continue to review full report at Codecov.
|
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
This seems reasonable to me but I wonder whether it would be worth trying to not include some of the large build-specific files if we aren't actually using them? (it looks like we just use a few files?)
| @@ -1,13 +1,11 @@ | |||
| #! /bin/sh | |||
| # Guess values for system-dependent variables and create Makefiles. | |||
| # Generated by GNU Autoconf 2.68 for expat 2.1.0. | |||
There was a problem hiding this comment.
Do we actually need to include this file? Because it's also an auto-generated file, I wonder if we might be able to do without if we don't actually need it?
|
Yay, now everything is passing including windows :). @astrofrog - Right, I dumped everything as there is no existing script to cleanup this mess. But we just need a few files ("xmlparse.c", "xmlrole.c", "xmltok.c", "xmltok_impl.c", "loadlibrary.c", listed in setup_package), and probably a few headers. So we could make a cleanup script to at least remove makefiles, autotools files, vcproj, etc. |
|
Great that the CI passes! Indeed it looks like we have so it would make sense to include one for expat too. |
|
@saimn - can you squash the commits to avoid the large diff? |
|
@astrofrog - yes, will do! |
|
Also this will need a changelog. |
|
I squashed the commits adding and removing files, but kept the one about random flags as it contains some information, and also added the changelog entry. |
|
|
Should close #7594. Most important changes are in
expat_config.hwhich defines new variables, not sure if all of these changes are needed or desirable (the file was generated by a./configureon my laptop).