Repository navigation
Remove py2/py3 commentary in the dev build docs - #8289
Merged
Merged
Conversation
bsipocz
approved these changes
Dec 14, 2018
Codecov Report
@@ Coverage Diff @@
## master #8289 +/- ##
=======================================
Coverage 86.92% 86.92%
=======================================
Files 384 384
Lines 57995 57995
Branches 1060 1060
=======================================
Hits 50413 50413
Misses 6967 6967
Partials 615 615Continue to review full report at Codecov.
|
astrofrog
reviewed
Dec 15, 2018
| If you are using python 3 you will need to re-install after making changes to | ||
| the Astropy source code. Re-installing goes much faster than the initial install | ||
| because it typically does not require new compilation. | ||
| python setup.py develop |
Member
|
There was a long discussion back in #7295 regarding using |
Member
|
@pllim - I still stand by this PR. Almost a year passed on since the previous one, and |
Member
|
Thanks @parejkoj! |
bsipocz
added a commit
that referenced
this pull request
Dec 31, 2018
Remove py2/py3 commentary in the dev build docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This section was very confusing: we should just use
develop, and there is no such thing as python2 anymore!@bsipocz approved this change in person! ;-)