Skip to content

WIP: allow NDData as Table mixin column - #8226

Closed
taldcroft wants to merge 1 commit into
astropy:masterfrom
taldcroft:table-nddata
Closed

taldcroft wants to merge 1 commit into
astropy:masterfrom
taldcroft:table-nddata

Conversation

@taldcroft

Copy link
Copy Markdown
Member

This is a WIP and may not be suitable for merging because it requires a new subclass of NDData.

The issue is that propagating the info attribute requires overriding __getitem__, which will be slow (relative to the current C-code interface in numpy). It is technically feasible to do the same trick using in Column to make a Cython-based __getitem__.

Fixes #8159 .

@astropy-bot

astropy-bot Bot commented Jun 15, 2019

Copy link
Copy Markdown

Hi humans 👋 - this pull request hasn't had any new commits for approximately 6 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@astropy-bot

astropy-bot Bot commented Jul 17, 2019

Copy link
Copy Markdown

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

@astropy-bot astropy-bot Bot closed this Jul 17, 2019
@pllim pllim added the closed-by-bot Closed by stale bot label Jul 17, 2019
@taldcroft
taldcroft deleted the table-nddata branch October 1, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to use NDDataArray as a mix-in column in tables

2 participants