Skip to content

WIP Quantity masked array - #8133

Closed
mhvk wants to merge 8 commits into
astropy:masterfrom
mhvk:quantity-masked-array
Closed

mhvk wants to merge 8 commits into
astropy:masterfrom
mhvk:quantity-masked-array

Conversation

@mhvk

@mhvk mhvk commented Nov 15, 2018

Copy link
Copy Markdown
Contributor

A revival of #6005 so @astrofrog can have a look. DO NOT MERGE.

I'm still far from sure this is the right way; a Masked mixin similar to the new Distribution class in uncertainty might make more sense.

@astropy-bot

astropy-bot Bot commented Nov 15, 2018

Copy link
Copy Markdown

Hi there @mhvk 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I see this is a work in progress pull request. I'll report back on the checks once the PR is ready for review.

If there are any issues with this message, please report them here.

3 similar comments
@astropy-bot

astropy-bot Bot commented Nov 15, 2018

Copy link
Copy Markdown

Hi there @mhvk 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I see this is a work in progress pull request. I'll report back on the checks once the PR is ready for review.

If there are any issues with this message, please report them here.

@astropy-bot

astropy-bot Bot commented Nov 15, 2018

Copy link
Copy Markdown

Hi there @mhvk 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I see this is a work in progress pull request. I'll report back on the checks once the PR is ready for review.

If there are any issues with this message, please report them here.

@astropy-bot

astropy-bot Bot commented Nov 15, 2018

Copy link
Copy Markdown

Hi there @mhvk 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I see this is a work in progress pull request. I'll report back on the checks once the PR is ready for review.

If there are any issues with this message, please report them here.

@pllim
pllim requested a review from astrofrog November 16, 2018 02:08
@astropy-bot

astropy-bot Bot commented Jun 15, 2019

Copy link
Copy Markdown

Hi humans 👋 - this pull request hasn't had any new commits for approximately 6 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@mhvk
mhvk force-pushed the quantity-masked-array branch from 0e6efa5 to ca94631 Compare June 15, 2019 15:36
@codecov

codecov Bot commented Jun 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #8133 into master will decrease coverage by 0.07%.
The diff coverage is 90.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8133      +/-   ##
==========================================
- Coverage   86.99%   86.92%   -0.08%     
==========================================
  Files         400      383      -17     
  Lines       59480    57930    -1550     
  Branches     1100     1056      -44     
==========================================
- Hits        51747    50356    -1391     
+ Misses       7092     6960     -132     
+ Partials      641      614      -27
Impacted Files Coverage Δ
astropy/units/core.py 95.45% <100%> (-0.44%) ⬇️
astropy/units/quantity.py 94.31% <89.87%> (+0.76%) ⬆️
astropy/convolution/__init__.py 62.5% <0%> (-37.5%) ⬇️
astropy/wcs/__init__.py 50% <0%> (-16.67%) ⬇️
astropy/visualization/units.py 68.08% <0%> (-5.5%) ⬇️
astropy/io/misc/asdf/tags/table/table.py 90% <0%> (-4.81%) ⬇️
astropy/coordinates/solar_system.py 71.33% <0%> (-3.67%) ⬇️
astropy/modeling/utils.py 83% <0%> (-3.37%) ⬇️
astropy/wcs/wcsapi/fitswcs.py 89.47% <0%> (-2.62%) ⬇️
astropy/wcs/wcsapi/low_level_api.py 94.73% <0%> (-2.41%) ⬇️
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9636ea...ca94631. Read the comment docs.

@bsipocz bsipocz added this to the v4.0 milestone Oct 21, 2019
@mhvk mhvk modified the milestones: v4.0, v4.1 Oct 24, 2019
@mhvk

mhvk commented Oct 24, 2019

Copy link
Copy Markdown
Contributor Author

I have a really nice update for this in the works, but not ready by tomorrow, so changing the milestone. Also, as discussed with @eteq offline, it probably is better not to introduce major new features in an LTS; ideally, we just have a nice release in which everything works well so people can safely upgrade.

@astropy-bot

astropy-bot Bot commented Nov 18, 2019

Copy link
Copy Markdown

Hi humans 👋 - this pull request hasn't had any new commits for approximately 5 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@astropy-bot astropy-bot Bot added the closed-by-bot Closed by stale bot label Dec 19, 2019
@astropy-bot

astropy-bot Bot commented Dec 19, 2019

Copy link
Copy Markdown

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

@mhvk

mhvk commented Jun 1, 2020

Copy link
Copy Markdown
Contributor Author

See #10423 for a much more developed version.

@mhvk

mhvk commented Apr 13, 2021

Copy link
Copy Markdown
Contributor Author

Superceded by #11127

@mhvk
mhvk deleted the quantity-masked-array branch April 13, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants