Skip to content

Interpolate NaN values only if they exist and nan_treatment='interpolate' - #8101

Closed
jamienoss wants to merge 2 commits into
astropy:masterfrom
jamienoss:make_nan_interpolation_conditional_on_the_existance_of_nan_values
Closed

jamienoss wants to merge 2 commits into
astropy:masterfrom
jamienoss:make_nan_interpolation_conditional_on_the_existance_of_nan_values

Conversation

@jamienoss

@jamienoss jamienoss commented Nov 9, 2018 •

Copy link
Copy Markdown
Contributor

I know we're way past the feature freeze for 3.1 but here's a one-liner for a major perf boost to convolution.convolve_fft().

figure_1

Signed-off-by: James Noss [email protected]

@astropy-bot

astropy-bot Bot commented Nov 9, 2018 •

Copy link
Copy Markdown

Hi there @jamienoss 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I see this is a work in progress pull request. I'll report back on the checks once the PR is ready for review.

If there are any issues with this message, please report them here.

@jamienoss
jamienoss force-pushed the make_nan_interpolation_conditional_on_the_existance_of_nan_values branch from 30be42d to 9f7740a Compare November 9, 2018 18:06
@jamienoss

Copy link
Copy Markdown
Contributor Author

Some FFT tests will fail. I'm investigating a possible issue with the normalization.

@astropy-bot

astropy-bot Bot commented Jun 15, 2019

Copy link
Copy Markdown

Hi humans 👋 - this pull request hasn't had any new commits for approximately 7 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@astropy-bot

astropy-bot Bot commented Jul 17, 2019

Copy link
Copy Markdown

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants