Repository navigation
deprecate _naxis1/2 - #7973
deprecate _naxis1/2#7973
Conversation
|
Hi there @nden 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
| __doctest_skip__ = ['WCS.all_world2pix'] | ||
|
|
||
| naxis_deprecated_message = """ | ||
| Private attributes "_naxis1" and "naxis2" have been deprecated since v 3.1. |
There was a problem hiding this comment.
remove space between v and 3.1
|
|
||
| @property | ||
| def _naxis1(self): | ||
| warnings.warn(naxis_deprecated_message, AstropyDeprecationWarning) |
There was a problem hiding this comment.
do we really need to deprecate this? I mean this was supposed to be private rather than in the public API, so no one should have used it
There was a problem hiding this comment.
It's been used for lack of a public property. It's used in STScI software and I believe someone else mentioned in a different issue they are using it.
There was a problem hiding this comment.
I've used it too...there really wan't any other way to get at the information, unfortunately.
There was a problem hiding this comment.
There's very little cost to including the deprecation warning, so I'm in favor 👍
6e8d64f to
a2b2ef1
Compare
|
Perhaps @MSeifert04 or @saimn can review as they have looked into this issue before. |
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
It looks good to me, just one minor comment
|
|
||
| __doctest_skip__ = ['WCS.all_world2pix'] | ||
|
|
||
| naxis_deprecated_message = """ |
There was a problem hiding this comment.
Minor: make this uppercase to make it clear it's a top-level constant
|
This is pretty straightforward, so I'll go ahead and merge - thanks @nden! |
This is a propagation of astropy/astropy#7973 Signed-off-by: James Noss <[email protected]>
This is a propagation of astropy/astropy#7973 Signed-off-by: James Noss <[email protected]>
Pin 4fc9f31af6c5659c3a59b66a387894c12203c946 and its regression selectors for reproducible runs. Source: astropy/astropy#7973
Note: This depends on #7962 and astrofrog#75.
This deprecates
Wcs._naxis1andWcs._naxis2in favor ofWCS.pixel_shape.Resolves #5461 and #4669 where there's a description of the problem.