Repository navigation
Added same note about memmap default to the fits.open docstring. - #7433
leahmfulmer wants to merge 3 commits into
Conversation
|
Hi there @LFulmer 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
|
|
||
| memmap : bool, optional | ||
| Is memory mapping to be used? | ||
| Is memory mapping to be used? ``memmap=True`` by default. This value is obtained from the configuration item ``astropy.io.fits.Conf.use_memmap``. |
There was a problem hiding this comment.
Nitpick: Please break long line into 2-3 lines (as needed).
p.s. Perhaps this could have been folded in #7432 but this is fine as standalone too.
|
I'm trying to help @LFulmer with this PR. In the branch |
|
Did you try rebase from |
|
OK, thanks, we'll throw out the branch and start from scratch! |
|
o_O don't have to be so drastic... try... Might need to force push. |
Responding to @saimn regarding adding the default information (memmap=True) to fits.open docstring.