Repository navigation
Responding to comments on PR for Issue #6497 - #7432
Closed
leahmfulmer wants to merge 1 commit into
Closed
leahmfulmer wants to merge 1 commit into
leahmfulmer wants to merge 1 commit into
Conversation
|
Hi there @LFulmer 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
pllim
reviewed
May 3, 2018
| array data of each HDU to be accessed with mmap, rather than being read into | ||
| memory all at once. This is particularly useful for working with very large | ||
| arrays that cannot fit entirely into physical memory. | ||
| arrays that cannot fit entirely into physical memory. Here ``memmap=True`` by default, and this value is obtained from the configuration item ``astropy.io.fits.Conf.use_memmap``. |
Member
There was a problem hiding this comment.
Nitpick: Please break the long line into two lines.
Contributor
|
I think this is exactly the same as #7429, so closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed typo and added reference to configuration item astropy.io.fits.Conf.use_memmap.
EDIT: Fix #6497