Skip to content

Adding python 3.7-dev to the travis matrix - #7416

Closed
bsipocz wants to merge 4 commits into
astropy:masterfrom
bsipocz:travis_python3.7
Closed

bsipocz wants to merge 4 commits into
astropy:masterfrom
bsipocz:travis_python3.7

Conversation

@bsipocz

@bsipocz bsipocz commented May 1, 2018

Copy link
Copy Markdown
Member

The release is almost out, so adding this now won't hurt. If it fails I'll move it to the allowed to fail section

@astropy-bot

astropy-bot Bot commented May 1, 2018 •

Copy link
Copy Markdown

Hi there @bsipocz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issue with this pull request:

  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix this? Thanks!

If there are any issues with this message, please report them here.

@bsipocz
bsipocz requested a review from saimn May 1, 2018 20:03
@saimn

saimn commented May 1, 2018

Copy link
Copy Markdown
Contributor

Looks like h5py is not yet compatible. Shall we run tests with fewer dependencies?

@bsipocz

bsipocz commented May 1, 2018

Copy link
Copy Markdown
Member Author

@saimn - Yes, I'm removing any that is not yet available.

@saimn

saimn commented May 2, 2018

Copy link
Copy Markdown
Contributor

It seems that many packages are not yet ready:

Failed building wheel for pyyaml
Failed building wheel for pandas
Failed building wheel for bintrees
Failed building wheel for scikit-image
Failed building wheel for scipy
Failed cleaning build dir for scipy

@bsipocz
bsipocz force-pushed the travis_python3.7 branch from c1700a5 to 4ae08e1 Compare May 2, 2018 03:40
@bsipocz

bsipocz commented May 2, 2018

Copy link
Copy Markdown
Member Author

@saimn @pllim - I'm not sure how to proceed here, put it into allowed to fail and wait for fixes in follow-up PR, or do those PR against this one and merge once everything passes?

@pllim

pllim commented May 2, 2018 •

Copy link
Copy Markdown
Member

IMHO we can just wait until conda (and others) catches up. I doubt everyone is going to suddenly upgrade to Python 3.7 the day it comes out. I would even be so bold to propose a 2-week window after Python 3.7 release to do any remaining compatibility work on our side (they would be high priority then, of course). What do you think?

@saimn

saimn commented May 2, 2018

Copy link
Copy Markdown
Contributor

Maybe we can wait until the first release candidate ? This should come at the end of may: https://www.python.org/dev/peps/pep-0537/#id5

@bsipocz

bsipocz commented May 2, 2018

Copy link
Copy Markdown
Member Author

OK, then I'll just leave this here and and update as required when the RC is out.

@bsipocz bsipocz modified the milestones: v2.0.7, v2.0.8 May 30, 2018
@saimn

saimn commented Jun 13, 2018

Copy link
Copy Markdown
Contributor

Python 3.7.0rc1 is available, and final version scheduled to 2018-06-27, so it would be good to test in the coming weeks. Not sure if it is available with conda though.

@pllim

pllim commented Jun 13, 2018

Copy link
Copy Markdown
Member

Thanks for the update @saimn . FWIW I restarted the Travis CI build here. 🤞

@pllim

pllim commented Jun 14, 2018

Copy link
Copy Markdown
Member

@bsipocz
bsipocz force-pushed the travis_python3.7 branch from 4ae08e1 to c216015 Compare June 15, 2018 14:10
@bsipocz

bsipocz commented Jun 15, 2018

Copy link
Copy Markdown
Member Author

Some of the failures we see look the same that @saimn has reported upstream (cython/cython#2043) and that has hopefully been addressed in the latest cython release. (Failures were seen with 0.27.3)

@pllim

pllim commented Jun 15, 2018

Copy link
Copy Markdown
Member

@pllim

pllim commented Jun 27, 2018

Copy link
Copy Markdown
Member

Python 3.7 was released today. FYI

@pllim pllim closed this Jun 27, 2018
@pllim pllim reopened this Jun 27, 2018
@pllim

pllim commented Jun 27, 2018

Copy link
Copy Markdown
Member

(Sorry, press wrong button, hence the accidental closing.)

This is just an experiment. Not meant to be merged.
@mhvk

mhvk commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

@bsipocz - the conflict is because of the numpy>=1.13 merge, which adjusted .travis.yml. Possibly a good excuse to double-check that you like the changes I made.

@pllim

pllim commented Jun 29, 2018

Copy link
Copy Markdown
Member

I was about to rebase and push it back out here.

@pllim

pllim commented Jun 29, 2018

Copy link
Copy Markdown
Member

Update: I changed my mind and opened #7607 instead. I went the lazy route and squashed commits and moved things around, so I'd rather we have multiple PRs than losing history here.

@pllim

pllim commented Jun 29, 2018

Copy link
Copy Markdown
Member

My attempt over at #7607 did not get very far. It looks like we might have to give the world a few weeks to make packages available here and there.

@mhvk

mhvk commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

You mean numpy/numpy#11418?

@mhvk

mhvk commented Jul 2, 2018

Copy link
Copy Markdown
Contributor

@bsipocz - #7617 should have fixed at least the astropy-related problems, so maybe worth reviving this one! Note that I removed the no-changelog-needed label since somewhere we should mention that we now support 3.7, and this PR seemed as good as any - though I'm quite happy to have a new issue for that if that works better.

@saimn

saimn commented Jul 2, 2018

Copy link
Copy Markdown
Contributor

Sadly Travis support for Python 3.7 is not ready yet: travis-ci/travis-ci#9815
Any idea for the conda side ? I think I read that they now have Python 3.7, though the scientific packages are maybe not yet ready.

@bsipocz

bsipocz commented Jul 25, 2018 •

Copy link
Copy Markdown
Member Author

closing in favour of #7607

@bsipocz bsipocz closed this Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants