Skip to content

Update extern cfitsio package to 3.44 for bug fixes - #7370

Merged
bsipocz merged 2 commits into
astropy:masterfrom
drdavella:update-cfitsio-again
Apr 13, 2018
Merged

Update extern cfitsio package to 3.44 for bug fixes#7370
bsipocz merged 2 commits into
astropy:masterfrom
drdavella:update-cfitsio-again

Conversation

@drdavella

@drdavella drdavella commented Apr 13, 2018

Copy link
Copy Markdown
Contributor

This resolves #7367.

@astropy-bot

astropy-bot Bot commented Apr 13, 2018 •
edited
Loading

Copy link
Copy Markdown

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@drdavella drdavella added this to the v3.0.2 milestone Apr 13, 2018
@drdavella

drdavella commented Apr 13, 2018

Copy link
Copy Markdown
Contributor Author

@bsipocz do we need a separate PR to backport to 2.0.x or how is that being handled these days?

@bsipocz

bsipocz commented Apr 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

This may be suitable to be backported as is. Last time it needed to be done separately as a previous update was missing from the LTS branch.
If there is some issue with the backport, I'll definitely ping you.

@bsipocz bsipocz modified the milestones: v3.0.2, v2.0.6 Apr 13, 2018
eteq
eteq approved these changes Apr 13, 2018
View reviewed changes

@eteq eteq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the backport requires some manual tweaking, I think we put the changelog entry in the 2.0.6 section. Other than that this looks good, though!

@bsipocz
bsipocz merged commit 4197869 into astropy:master Apr 13, 2018
@bsipocz

bsipocz commented Apr 13, 2018

Copy link
Copy Markdown
Member

thanks @drdavella

@drdavella
drdavella deleted the update-cfitsio-again branch April 16, 2018 12:20
bsipocz added a commit that referenced this pull request Apr 19, 2018
@bsipocz
Merge pull request #7370 from drdavella/update-cfitsio-again
fa5d6a3 
Update extern cfitsio package to 3.44 for bug fixes
bsipocz added a commit that referenced this pull request Apr 19, 2018
@bsipocz
Merge pull request #7370 from drdavella/update-cfitsio-again
dcc78e6 
Update extern cfitsio package to 3.44 for bug fixes
bsipocz added a commit that referenced this pull request Apr 23, 2018
@bsipocz
Merge pull request #7370 from drdavella/update-cfitsio-again
28c9c79 
Update extern cfitsio package to 3.44 for bug fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eteq eteq eteq approved these changes

Assignees

No one assigned

Labels

Bug io.fits

Projects

None yet

Milestone

v2.0.6

Development

Successfully merging this pull request may close these issues.

Update CFITSIO to 3.44

3 participants

@drdavella @bsipocz @eteq