Skip to content

Bump minimum Numpy version to 1.4 - #70

Merged
mdboom merged 1 commit into
astropy:masterfrom
mdboom:numpy/minimum-version
Nov 17, 2011
Merged

mdboom merged 1 commit into
astropy:masterfrom
mdboom:numpy/minimum-version

Conversation

@mdboom

@mdboom mdboom commented Nov 16, 2011

Copy link
Copy Markdown
Contributor

1.3 has some problems with byteswapping complex numbers that makes supporting them in io.vo almost impossible. I know @iguananaut had mentioned that 1.3 support for the upcoming io.fits is also annoying. Should we just bite the bullet and drop 1.3?

@astrofrog

Copy link
Copy Markdown
Member

I think this makes sense. I've had issues with 1.3 in the past for structured arrays, and these are going to be used in astropy.table.

@embray

embray commented Nov 16, 2011

Copy link
Copy Markdown
Member

The only issue I can see is that the last Ubuntu LTS release ships with 1.3. But the next LTS release is 12.04...which is probably sooner than we're likely to see significant Astropy adoption. So I don't see it as a likely issue...

@astrofrog

Copy link
Copy Markdown
Member

What about having a setup.py flag to force installation regardless of dependencies? That way, python setup.py install would raise an Exception saying that e.g. Numpy is too old, but if you really want to install it, you can do e.g. python setup.py install --force.

@embray

embray commented Nov 16, 2011

Copy link
Copy Markdown
Member

I don't really care either way, but that would be easy to add if others think it's a good idea.

@astrofrog

Copy link
Copy Markdown
Member

In any case I agree with not supporting 1.3 by default.

@eteq

eteq commented Nov 17, 2011

Copy link
Copy Markdown
Member

I vaugely prefer just requiring 1.4 because that'll be simpler/more-standard, but I'm fine with either solution.

mdboom added a commit that referenced this pull request Nov 17, 2011
Bump minimum Numpy version to 1.4
@mdboom
mdboom merged commit 30f77e8 into astropy:master Nov 17, 2011
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
@mdboom
mdboom deleted the numpy/minimum-version branch May 21, 2014 23:56
embray added a commit to embray/astropy that referenced this pull request Jan 23, 2015
astrofrog referenced this pull request in astrofrog/astropy Nov 23, 2016
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
Added Travis to validate JSON file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants