Skip to content

Better changelog entry for gh-6823 - #6901

Merged
bsipocz merged 1 commit into
astropy:masterfrom
mhvk:time-column-sandwich-changelog-change
Nov 27, 2017
Merged

Better changelog entry for gh-6823#6901
bsipocz merged 1 commit into
astropy:masterfrom
mhvk:time-column-sandwich-changelog-change

Conversation

@mhvk

@mhvk mhvk commented Nov 27, 2017

Copy link
Copy Markdown
Contributor

@taldcroft - here's the revised changelog entry. Feel free to edit directly if you think it is not clear.

@mhvk mhvk added this to the v3.0.0 milestone Nov 27, 2017
@mhvk
mhvk requested a review from taldcroft November 27, 2017 15:04
@astropy-bot

astropy-bot Bot commented Nov 27, 2017 •
edited
Loading

Copy link
Copy Markdown

Hi there @mhvk 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

taldcroft
taldcroft reviewed Nov 27, 2017
View reviewed changes

@taldcroft taldcroft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASCII is an acronym and needs to be all uppercase. Otherwise fine.

bsipocz
bsipocz previously requested changes Nov 27, 2017
View reviewed changes

@bsipocz bsipocz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please move the changelog entry back to 3.0 as the PR got remilestoned since? Never mind me, should have checked it more carefully, it's already been moved.

@bsipocz
bsipocz dismissed their stale review November 27, 2017 15:46

mistake on my part, the change already been moved

@mhvk
mhvk force-pushed the time-column-sandwich-changelog-change branch from 14ee13a to 27534ad Compare November 27, 2017 15:56
@mhvk

mhvk commented Nov 27, 2017

Copy link
Copy Markdown
Contributor Author

OK, changed to ASCII

@bsipocz
bsipocz merged commit 5dec6bb into astropy:master Nov 27, 2017
@bsipocz

bsipocz commented Nov 27, 2017

Copy link
Copy Markdown
Member

Thanks @mhvk! Merging now, so I see less issues in the consistency report now when trying to backport things.

@mhvk
mhvk deleted the time-column-sandwich-changelog-change branch November 27, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taldcroft taldcroft taldcroft left review comments
@bsipocz bsipocz bsipocz approved these changes

Assignees

No one assigned

Labels

Docs no-changelog-entry-needed

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mhvk @bsipocz @taldcroft