Repository navigation
Support Time in table hstack, vstack and join - #6888
Conversation
|
Hi there @taldcroft 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
930ab5d to
4107a2e
Compare
|
This is not to be backported to the v3.0.x branch as the coordinators decided this would need more testing before it makes it to a release. |
4107a2e to
60366ea
Compare
60366ea to
ceb3fe6
Compare
|
@taldcroft - now that #6028 is merged, can you rebase this? |
|
@astrofrog - yes, in fact I rebased already a few days ago, so there are now just 6 commits. |
|
The circleci fail is unrelated: Is this fixed in the most recent master? |
|
And of course I will fix the changelog to put into 3.1. |
I think so, I increased the tolerance in this test a couple of days ago |
| input ``cols`` and has ``length`` rows. | ||
|
|
||
| This is intended for creating an empty column object whose elements can | ||
| be set in-place for table operations like join or vstack. |
There was a problem hiding this comment.
Since this is in the astropy.time module, it might not be clear what columns refers to. Maybe saying 'multiple time objects' would make more sense? Or maybe explain more about the Table mixin functionality here.
|
@taldcroft @mhvk - I see this is ready for review for a while, do you have any update on it? |
|
@bsipocz - I have rebased again and addressed the review comments. From my perspective this is good to go (pending tests of course). |
|
Thanks @mhvk! |
This PR adds support for Time objects to be used in table operations hstack, vstack and join. It builds off the support for setting and masking in #6028.
The only substantive code change is in the
new_likemethod to create a new emptyTimeobject based on a list of inputTimeobjects.