Repository navigation
Deprecate "recommended_units" for representations - #6858
Merged
mhvk merged 3 commits intoDec 21, 2017
Merged
Conversation
|
Hi there @mhvk 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
adrn
approved these changes
Dec 21, 2017
adrn
left a comment
adrn
left a comment
Member
There was a problem hiding this comment.
Sorry it took me so long to review. I'm fine with doing this for 3.0, and this PR looks good to me!
This allows on to remove the explicit setting of the recommended unit of degrees for every representation.
Since the defaults cover all its internal use, and this should be dealt with in the frames that actually do something with it.
mhvk
force-pushed
the
representation-deprecate-recommended-units
branch
from
December 21, 2017 22:28
d4d3e48 to
7b8cc09
Compare
mhvk
added
Affects-release
zzz 💤 merge-when-ci-passes
Contributor
Author
|
Approved by @adrn and now rebased, with tests passing, so I'll merge myself... |
2 of 3 tasks
2 tasks
16 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recommended_unitsof representations were used to ensure that any angles are presented in degrees in sky coordinates and frames. It is strange to have classes define an attribute that they do not use at all, and, more generally, it seems more logical to do this in frames itself (which already allow overriding units for specific representations). Still, this PR has two commits, one that replaces the actual definitions ofrecommended_unitswith a default of degree for angles, and a second that deprecates the attribute.