Repository navigation
Reverting temporary xfails for semi-randomly failing test - #6725
Conversation
…ese tests now indeed always pass
|
Hi there @bsipocz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here |
|
This gets rid of 1, #6722 gets rid of another, but what about the 3rd xpass? Did I miss something? |
|
This one actually gets rid of 2, as the |
|
Oh, magic! Thanks for the clarification. |
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
I think this is a good time to try, since the bug may well have been solved by #6714. See #6291 (comment)
|
I'm going to merge, since I agree that we should try... |
Reverting temporary xfails for semi-randomly failing test
This PR is the revert of #6351 that was temporarily put in place before the 2.0 release.
The nature of the original bug (#6291) was such as we couldn't consistently reproduce it, and the only way to really see whether it's solved in the meantime is to let CI catch possible failures.
Ideally this should be backported to the 2.0.x branch, but we should milestone it as such when we are certain that the bug is gone.
(Thus I'm adding the "manual backport" label for now to make sure it'll be noticed at release times...)