Repository navigation
Revert 6277 - #6342
Merged
Merged
Revert 6277#6342
Conversation
This reverts commit 433e080.
taldcroft
added
Affects-dev
|
Hi there @taldcroft 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 |
bsipocz
added
zzz 💤 merge-when-ci-passes
astrofrog
approved these changes
Jul 6, 2017
| circular reference cycle. This change means that expressions like | ||
| ``col[3:5].info`` will now fail because at the point of the ``info`` | ||
| property being evaluated the ``col[3:5]`` weak reference is dead. Instead | ||
| force a reference with ``c = col[3:5]`` followed by |
Member
There was a problem hiding this comment.
Just a note that this behavior wasn't ideal anyway (col[3:5].info not working) so maybe we can find a better solution in future.
Member
|
Since @astrofrog approved, I'm going ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6291.
But unfixes #6276. The memory leak there is at least well-understood and has been there for a couple of releases with no complaints. The plan is to come back to this after the 2.0 release and re-do #6277 in a way that doesn't introduce the semi-random exceptions.