Repository navigation
Conversation
Contributor
Author
|
Closing since I cannot get this to work well -- too fragile. |
Member
|
I was just looking at this. I can't understand why it is failing so weirdly in CI. I agree in principle with the basic idea ... except that it seems to add complexity to something that is already pretty difficult for me to understand (and I wrote the original!). |
Contributor
Author
|
The failure is because if you set an attribute that also exists on the class, it gets stored in |
Member
|
Ah right, then you need to implement |
Contributor
Author
|
Agreed, I didn't want to go the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #6277 for fixing #6276. Instead of making
_parenta weak reference, it no longer stores the info instance on the parent, but instead just stores the information there. So, an instance is recreated every timeinfois accessed, but it is quickly updated. It has the advantage that nothing needs to be adjusted, but perhaps can be done better. cc @taldcroft, @MSeifert04 (who seems to understand reference counting better...)p.s. I'm not 100% sure we use the descriptor interface optimally...