Repository navigation
Removing deprecations in preparation of v2.0 - #6170
Conversation
bsipocz
added
coordinates
cosmology
io.fits
io.votable
modeling
nddata
table
units
utils
visualization
wcs
labels
|
@bsipocz Removing the deprecations in modeling and wcs is fine. Thanks for taking care of this. |
|
@bsipocz -- the nddata changes look good, thanks for doing this! |
| or open the file with lazy_load_hdus=False to read all | ||
| the HDUs into memory immediately upon opening the file. | ||
| """), AstropyDeprecationWarning) | ||
|
|
|
@bsipocz - removals in |
|
nddata and io.fits look good. Thanks for all the work 👍 |
|
Thanks everyone for the feedbacks. There are still a few submodules that needs to be checked: @aconley, @nhmc - Could either of you confirm please that the cosmology deprecations can be removed? @pllim - Could you check the @larrybradley @astrofrog - Could you have a look at the visualization removal? |
8710619 to
104542e
Compare
104542e to
c71679f
Compare
|
Hmm, I worry a little that (Other than that I'm happy with this) |
|
Well, I was a user, but I updated my code when I started getting deprecation warnings, so the system worked :) I think it's probably fine to remove by now... |
|
@bsipocz , |
|
@eteq - just in case you were confused by the two sets of deprecation messages: |
|
@bsipocz |
|
I will check the cosmology cases tonight, unless @aconley beats me to it. |
|
I'm on vacation ATM, so I think you're gonna get there first.
…On Mon, Jun 12, 2017 at 3:41 PM Neil Crighton ***@***.***> wrote:
I will check the cosmology cases tonight, unless @aconley
<https://github.com/aconley> beats me to it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6170 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB62hkKtdpSmG2yyffVxRO205cKNzBtHks5sDbB7gaJpZM4N0y3X>
.
|
|
@bsipocz - Removing the cosmology deprecations seems fine to me. Thanks! |
|
Now that this has got the green light from every affected subpackage, I'm going ahead and merge. Thanks for the review! |
…vals_for_20 Removing deprecations in preparation of v2.0
…vals_for_20 Removing deprecations in preparation of v2.0
This is a rather controversial PR, and I'm very much interested in what you all think.
I've gone ahead and removed (hopefully) every deprecations that was present in v1.3. According to APE2, we ought to keep deprecations around for one feature release. Since 2.0 will be our new LTS, I suggest to remove all of these deprecation now rather than dragging them along for 2 more years.
Obviously submodule maintainers have the insight whether we need to keep any of these for a longer cool off period.
(This will need a changelog that I add once we agreed on the deprecations that are needed to be kept further in core.)