Repository navigation
Remove astropy.utils OrderedDict wrapper (deprecated since 1.2) - #6157
Merged
Merged
Conversation
Member
Author
|
Rats, guessed wrong on the PR number, will fix. |
Member
|
LGTM... |
bsipocz
approved these changes
Jun 5, 2017
Member
|
Nice catch. Also @taldcroft, you may be interested in https://github.com/astropy/astropy-tools/blob/master/next_pr_number.py |
saimn
added a commit
to saimn/astropy
that referenced
this pull request
Jun 6, 2017
Note these were only issuing a warning before importing the stdlib modules. Follows astropy#4462 astropy#4463 astropy#4464, and similar to astropy#5975 and astropy#6157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Astropy originally had its own implementation of OrderedDict for Py 2.6. In astropy 1.2 support for Py2.6 was dropped and it was replaced with a wrapper for
collections.OrderedDictwith a deprecation warning. This PR finally removes it completely.