Repository navigation
Fix bug that caused Sphinx warnings for WCSAxes - #6063
Merged
Merged
Conversation
…at could change direction mid-axis, such as EllipticalFrame. Also ensure that empty tick labels do not cause any warnings.
astrofrog
force-pushed
the
fix-wcsaxes-label-bug
branch
from
May 12, 2017 18:02
af54167 to
c0474b2
Compare
pllim
reviewed
May 12, 2017
|
|
||
| - Fix a bug that caused labels to be missing from frames with labels that | ||
| could change direction mid-axis, such as EllipticalFrame. Also ensure | ||
| that empty tick labels do not cause any warnings. |
2 tasks done
Member
Author
|
This is ready if tests pass! |
Member
|
Thanks @astrofrog! |
bsipocz
added a commit
that referenced
this pull request
May 23, 2017
Fix bug that caused Sphinx warnings for WCSAxes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that caused labels to be missing from frames with labels that could change direction mid-axis, such as EllipticalFrame. Also ensure that empty tick labels do not cause any warnings.
Fixes #6002
Note that this still needs a regression test, which I'll add while on the✈️
cc @pllim @bsipocz (turns out this was a real bug!)