Skip to content

[EXP] Increase default remote timeout - #6001

Merged
bsipocz merged 1 commit into
astropy:masterfrom
pllim:fix-remote-timeout
May 8, 2017
Merged

bsipocz merged 1 commit into
astropy:masterfrom
pllim:fix-remote-timeout

Conversation

@pllim

@pllim pllim commented May 3, 2017 •

Copy link
Copy Markdown
Member

Increase default remote timeout to see if that helps with remote tests being flaky. This was part of #5997 but then taken out.

Related discussion: #5994

c/c @mhvk @bsipocz

TODO:

  • Add milestone.
  • Add change log. (Not needed.)

@bsipocz

bsipocz commented May 4, 2017

Copy link
Copy Markdown
Member

@pllim - This looks good to me given the assumption this will help the tests pass. If they become unstable again, we can revert the default again.

I don't think this need a changelog, and milestone doesn't matter much as the bugfix branch will only have a few CI runs before release.

@pllim

pllim commented May 4, 2017

Copy link
Copy Markdown
Member Author

Well... Look at that... Remote tests failing even here! Maybe this is not the correct solution after all. 🤔

@bsipocz

bsipocz commented May 4, 2017

Copy link
Copy Markdown
Member

@pllim - let's hope it was a fluke, only one of the remote ones were failing (now restrted) while previously it was all of them.

@pllim pllim added this to the v2.0.0 milestone May 4, 2017
@pllim

pllim commented May 4, 2017

Copy link
Copy Markdown
Member Author

That test passed now. Remaining failures unrelated.

@bsipocz

bsipocz commented May 8, 2017

Copy link
Copy Markdown
Member

There are a few timeouts again, so I'm merging this in the hope it will have have some positive effect for those.

@bsipocz
bsipocz merged commit d9012e7 into astropy:master May 8, 2017
@pllim
pllim deleted the fix-remote-timeout branch May 8, 2017 12:24
@pllim

pllim commented May 8, 2017

Copy link
Copy Markdown
Member Author

@mhvk

mhvk commented May 8, 2017

Copy link
Copy Markdown
Contributor

Lovely, I'll add divmod shortly.

@pllim

pllim commented May 8, 2017

Copy link
Copy Markdown
Member Author

Ops, and also this but we'll see if it is consistent or transient.

EarthLocation.of_address('1002 Holy Grail Court, St. Louis, MO') 

@mhvk

mhvk commented May 9, 2017

Copy link
Copy Markdown
Contributor

@pllim

pllim commented May 9, 2017

Copy link
Copy Markdown
Member Author

@mhvk , did you post the wrong link? It shows green with

8985 passed, 121 skipped, 80 xfailed, 3 xpassed, 1 pytest-warnings in 394.27 seconds 

@mhvk

mhvk commented May 9, 2017

Copy link
Copy Markdown
Contributor

Ah, I hadn't realised that if one restarts a test, the old log gets overwritten...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants