Repository navigation
Deprecate emu unit - #5906
Deprecate emu unit#5906
Conversation
916c252 to
44505db
Compare
|
@pllim - I like this approach! I wonder, though, whether it wouldn't make sense to follow Also, obviously needs some mention in the documentation... |
|
Re: "add" vs "set". No particular reason. It was just cut-and-paste. And apparently I chose the wrong module. Fixed that in the second commit. Re: Documentation. It is auto-generated. The following will appear at the end of the API documentation. Given that the unit is deprecated, I decided against giving it extra publicity, as we do not want to encourage people to use it (but it is there if they really, really want to). |
|
@pllim - OK, all looks good. Feel free to merge once the tests have passed. |
|
hm, |
|
We can always wait till Apr 1 to merge, it is not that far away. 😂 |
|
@bsipocz , then there is no easy way to find out what unit is deprecated. Also, this provides a consistent API presentation. So, I am against removing the table but I will if overruled. |
|
Since this is approved and tests passed, merging. |

Fix #4918 , where user was confused by the "emu" unit due to ambiguous definition of that term.
Supersede #5787 .
A subset of #5793. And this follows one of the suggestions there by @mhvk . Perhaps @eteq can utilize this new module for his work on #5661.