Skip to content

Fixing coveralls reporting - #5810

Merged
bsipocz merged 1 commit into
astropy:masterfrom
bsipocz:coverage_test
Feb 15, 2017
Merged

Fixing coveralls reporting#5810
bsipocz merged 1 commit into
astropy:masterfrom
bsipocz:coverage_test

Conversation

@bsipocz

@bsipocz bsipocz commented Feb 15, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Apparently we didn't compared to the correct string, so no wonder coveralls never picked up the results.

Fix #5701

@astrofrog

astrofrog commented Feb 15, 2017

Copy link
Copy Markdown
Member

Ha, I see you reached the same conclusion as me in #5506 (comment) :)

@bsipocz

bsipocz commented Feb 15, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Yeap :) Didn't spot it straight away, but it was suspicious that both astropy and astroplan are failing while wcsaxes has no problems...

I'll clean up this PR and the fix here.

@pllim pllim added the testing label Feb 15, 2017
@pllim pllim mentioned this pull request Feb 15, 2017
Closed
@MSeifert04

MSeifert04 commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

This needs to be changed in the package template travis.yml as well, right? Great detective work 👍

@bsipocz

bsipocz commented Feb 15, 2017

Copy link
Copy Markdown
Member Author

Yes, once this one is fixed, I'm propagating the solution to the package template and whichever other packages picked it up from there, too.

@bsipocz bsipocz added this to the v1.3.1 milestone Feb 15, 2017
@bsipocz bsipocz changed the title TEST: see whether coveralls picks the build Fixing coveralls reporting Feb 15, 2017
@bsipocz bsipocz mentioned this pull request Feb 15, 2017
Merged
@bsipocz

bsipocz commented Feb 15, 2017

Copy link
Copy Markdown
Member Author

OK, so apparently 107 packages out of the 111 didn't customized the coverage jobs, two remembered to update the upload part, too, and now I've fixed the remaining two problematic one, astropy and astroplan. Also there is a PR in package template to avoid these kind of issues in the future.

@bsipocz

bsipocz commented Feb 15, 2017

Copy link
Copy Markdown
Member Author

travis failure is totally unrelated, so I'm merging this now.

@bsipocz
bsipocz merged commit 9a2ef14 into astropy:master Feb 15, 2017
bsipocz added a commit that referenced this pull request Feb 15, 2017
@bsipocz
Merge pull request #5810 from bsipocz/coverage_test
ec05e41 
Fixing coveralls reporting
@pllim

pllim commented Feb 15, 2017

Copy link
Copy Markdown
Member 
coverage/coveralls — First build on master at 84.23%

🎉 Thanks!

@bsipocz
bsipocz deleted the coverage_test branch September 16, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug no-changelog-entry-needed testing

Projects

None yet

Milestone

v1.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@bsipocz @astrofrog @MSeifert04 @pllim