Skip to content

Adding python 3.6 builds to travis - #5642

Merged
mhvk merged 7 commits into
astropy:masterfrom
bsipocz:travis_add_python36
Feb 11, 2017
Merged

mhvk merged 7 commits into
astropy:masterfrom
bsipocz:travis_add_python36

Conversation

@bsipocz

@bsipocz bsipocz commented Dec 23, 2016

Copy link
Copy Markdown
Member

Python 3.6 is out today, so we should add it to the matrix.

@astrofrog

Copy link
Copy Markdown
Member

@bsipocz - I wonder if it might make more sense to update the default from 3.5 to 3.6 and add an explicit 3.5 build?

@bsipocz

bsipocz commented Dec 24, 2016

Copy link
Copy Markdown
Member Author

@astrofrog - Sounds like a good plan. We should anyway wait with this PR until conda provides python 3.6 and packages. A related question: should we change the version in appveyor, too?

@astrofrog

Copy link
Copy Markdown
Member

@bsipocz - I would lean on the side of updating AppVeyor too

@mwcraig

mwcraig commented Dec 24, 2016

Copy link
Copy Markdown
Member

Python 3.6 is available on conda defaults now, along with the core packages (numpy, scipy, a few others). It will take them a couple weeks to build out the rest of the packages in defaults: https://groups.google.com/a/continuum.io/forum/m/?utm_medium=email&utm_source=footer#!msg/conda/QJenUjUWKYc/j2DdI9f6EAAJ

@bsipocz
bsipocz force-pushed the travis_add_python36 branch from 2535d30 to b7c50e7 Compare December 24, 2016 22:20
@bsipocz

bsipocz commented Dec 24, 2016

Copy link
Copy Markdown
Member Author

Thanks @mwcraig for the heads up. I've just force pushed this, so hopefully travis will work.

@mwcraig

mwcraig commented Dec 24, 2016

Copy link
Copy Markdown
Member

I've built 1.0.11, 1.2.2 and 1.3 on python 3.6 for astropy-ci-extras. Will move some of that to the astropy channel on Monday.

@mwcraig

mwcraig commented Dec 28, 2016

Copy link
Copy Markdown
Member

Still no h5py on python 3.6...

@astrofrog

Copy link
Copy Markdown
Member

Nor Matplotlib. I think we'll need to be patient.

@bsipocz
bsipocz force-pushed the travis_add_python36 branch 2 times, most recently from f18d722 to 435298c Compare January 4, 2017 12:44
@bsipocz
bsipocz force-pushed the travis_add_python36 branch from 435298c to 90f7e22 Compare January 20, 2017 00:51
@bsipocz

bsipocz commented Jan 20, 2017

Copy link
Copy Markdown
Member Author

This PR also removes the sphinx version limitation (it was needed with <1.3 helpers, see #5568)

@bsipocz

bsipocz commented Jan 24, 2017

Copy link
Copy Markdown
Member Author

I've temporarily added conda-forge as a channel for the py3.6 builds to pick up the latest setuptools. Indeed it helped, and the weird error disappeared, but now there are other mpl related failures.
cc @astrofrog @MSeifert04

https://travis-ci.org/astropy/astropy/jobs/194574394

@astrofrog

Copy link
Copy Markdown
Member

@bsipocz - can you rebase and try again without conda-forge? We really don't want to be using conda-forge for the CI, mixing conda-forge and defaults leads to all kinds of fun.

@bsipocz

bsipocz commented Feb 9, 2017

Copy link
Copy Markdown
Member Author

@astrofrog - Sure. I suspect it will still fail due to the old setuptools on defaults, and also due to the mpl issues.

@bsipocz
bsipocz force-pushed the travis_add_python36 branch from 9ca8d2e to d247d11 Compare February 10, 2017 14:25
@mhvk

mhvk commented Feb 10, 2017

Copy link
Copy Markdown
Contributor

It actually seems to have worked, with one probably correct error for a \s escape sequence in a string (should this be a byte string at all? Maybe just a raw string?):

File "/home/travis/build/astropy/astropy/astropy/config/configuration.py", line 601

    content = re.sub(b'\njquery_url\s*=\s*[^\n]+', b'', content)

@bsipocz
bsipocz force-pushed the travis_add_python36 branch from d3caae8 to b92e97f Compare February 11, 2017 16:10
@bsipocz
bsipocz force-pushed the travis_add_python36 branch from 9953358 to 4b373a2 Compare February 11, 2017 19:18
@bsipocz

bsipocz commented Feb 11, 2017 •

Copy link
Copy Markdown
Member Author

This PR now includes a temporary xfail for the windows version of the tests that are failing with np 1.12. The xfail can be removed once #5797 is fixed.

@bsipocz

bsipocz commented Feb 11, 2017

Copy link
Copy Markdown
Member Author

🎉 this is all green now, we can start testing with python3.6!

@mhvk

mhvk commented Feb 11, 2017

Copy link
Copy Markdown
Contributor

Fantastic! Looked over it once more and think all is OK, so merging!

@mhvk
mhvk merged commit d827f35 into astropy:master Feb 11, 2017
@astrobot

Copy link
Copy Markdown

@mhvk - thanks for merging this! However, I noticed the following issue with this pull request:

  • The milestone has not been set

Would it be possible to fix this? Thanks!

If you believe the above to be incorrect (which I - @astrobot - very much doubt) you can ping @astrofrog

@bsipocz bsipocz added this to the v1.3.1 milestone Feb 11, 2017
bsipocz pushed a commit that referenced this pull request Feb 14, 2017
@bsipocz
bsipocz deleted the travis_add_python36 branch September 16, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants