Repository navigation
Emit warning when assigned string value is truncated - #5624
Merged
Merged
Conversation
hamogu
approved these changes
Dec 18, 2016
| t = table.Table([['aa', 'bb']], names=['a']) | ||
|
|
||
| with catch_warnings() as w: | ||
| from inspect import currentframe, getframeinfo |
Member
There was a problem hiding this comment.
Not needed here. Move to the next catch_warnings block for readability
Member
Author
There was a problem hiding this comment.
OK, I have done this locally.
Member
|
Great! This has been bugging me for a while 🎉 |
Member
Author
|
#5700 has been bugging me for 4 years... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #5551 so that a warning is emitted if a string value gets truncated when assigning in-place to a string column item.
There will be a performance penalty, but I think it is not too bad given that setitem is already using pure-Python code. Quick timeit testing showed that the difference is within the run-to-run uncertainty.