Skip to content

Adding workaround to the sphinx builds - #5568

Merged
astrofrog merged 1 commit into
astropy:masterfrom
bsipocz:travis_sphinx_version
Dec 7, 2016
Merged

astrofrog merged 1 commit into
astropy:masterfrom
bsipocz:travis_sphinx_version

Conversation

@bsipocz

@bsipocz bsipocz commented Dec 7, 2016

Copy link
Copy Markdown
Member

until the new astropy-helpers is out with the fix for astropy/astropy-helpers#274.
Version 1.4.9 works locally, but 1.5 gives the deprecation warnings.

cc @eteq @astrofrog

@astrofrog
astrofrog merged commit e07f6b3 into astropy:master Dec 7, 2016
@astrobot

astrobot commented Dec 7, 2016

Copy link
Copy Markdown

@astrofrog - thanks for merging this! However, I noticed the following issue with this pull request:

  • The milestone has not been set

Would it be possible to fix this? Thanks!

This is an experimental bot being written by @astrofrog - let me know if the message above is incorrect!

@astrofrog astrofrog added this to the v1.3.0 milestone Dec 7, 2016
@MSeifert04

Copy link
Copy Markdown
Contributor

@bsipocz Is this related to this failure in ccdproc?

@bsipocz

bsipocz commented Dec 7, 2016 •

Copy link
Copy Markdown
Member Author

@MSeifert04 - Yes, this is a failure everywhere that uses astropy-helpers <1.3 and Sphinx >=1.5. I'm about to open a fix for the helpers now. You can always set the SPHINX_VERSION='<1.5' to the travis file, just like in this PR.

@bsipocz

bsipocz commented Dec 7, 2016

Copy link
Copy Markdown
Member Author

@astrofrog @eteq - Since the astropy-helpers 1.3 is imminent I think it makes sense to do the fix there, or would you prefer to add back a version limitation to ci-helpers?

@MSeifert04

Copy link
Copy Markdown
Contributor

ok, thanks. I was wondering what happened there.

@eteq

eteq commented Dec 7, 2016

Copy link
Copy Markdown
Member

@bsipocz - we won't necessarily do a final helpers release for another week, so I think its probably best to back up ci-helpers until then, as otherwise affiliated packages will be seeing errors for a whole week...

@bsipocz

bsipocz commented Dec 7, 2016

Copy link
Copy Markdown
Member Author

Fair enough, I'm revering it then. Looking at the travis backlog it would take a few hours to get the green lights.

@bsipocz
bsipocz deleted the travis_sphinx_version branch September 16, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants