Skip to content

Conversation

@MSeifert04
Copy link
Contributor

@MSeifert04 MSeifert04 commented Dec 3, 2016

@taldcroft That print (#5427) was for debugging purposes, right?

@taldcroft
Copy link
Member

Ugh, yes, it should be removed.

@MSeifert04
Copy link
Contributor Author

Test failures (probably) because the astropy server is down.

@taldcroft
Copy link
Member

OK, I'm going ahead and merging. Thanks for the catch @MSeifert04!

@taldcroft taldcroft merged commit 59d32b6 into astropy:master Dec 3, 2016
@astrobot
Copy link

astrobot commented Dec 3, 2016

@taldcroft - thanks for merging this! However, I noticed the following issues with this pull request:

  • The milestone has not been set
  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix these? Thanks!

This is an experimental bot being written by @astrofrog - let me know if the message above is incorrect!

@taldcroft taldcroft added Affects-dev PRs and issues that do not impact an existing Astropy release io.ascii labels Dec 3, 2016
@taldcroft taldcroft added this to the v1.3.0 milestone Dec 3, 2016
@taldcroft
Copy link
Member

Addressed astrobot complaints.

@MSeifert04 MSeifert04 deleted the followup-5427 branch December 3, 2016 14:12
@MSeifert04
Copy link
Contributor Author

@taldcroft Thanks for merging. 👍

#5427 is marked for 1.0.11 any reason not to backport this as well?

@taldcroft taldcroft modified the milestones: v1.0.11, v1.3.0 Dec 3, 2016
@taldcroft
Copy link
Member

@MSeifert04 - I changed the milestone to 1.0.11.

eteq pushed a commit that referenced this pull request Dec 21, 2016
Remove debugging "print" introduced in #5427
eteq pushed a commit that referenced this pull request Dec 21, 2016
Remove debugging "print" introduced in #5427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release io.ascii no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants