Replace use of off_t by size_t in cparser #5502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix astropy#5497, see there for discussion.
saimn
force-pushed
the
fix-cparser-segfault
branch
from
20d52c6 to
102e58c
Compare
pllim
added
Affects-dev
Contributor
|
hm, why didn't CircleCI pick up this PR? Do you have CircleCI activated on your fork or is it just not based on current master? |
Member
|
@MSeifert04 - ah, there was a setting that needed to be enabled - done now |
Member
|
Let's see if the good old fashioned close/open triggers it |
Member
|
Yay \o/ |
Contributor
Author
|
@astrofrog - Great, and the tests now pass on CircleCI 😃 |
Member
|
@saimn - great, thanks! |
eteq
pushed a commit
that referenced
this pull request
Dec 21, 2016
Replace use of off_t by size_t in cparser
eteq
pushed a commit
that referenced
this pull request
Dec 21, 2016
Replace use of off_t by size_t in cparser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #5497, see there for discussion.