Repository navigation
Fix mistake in ECSV reader docstring and make example testable - #5450
Merged
Merged
Conversation
Member
Member
Author
|
There was one more case where an example in APE6 incorrectly had "type:" instead of "datatype:". |
Member
Author
|
I've attached a commit that applies the "type:" -> "datatype:" fix, and changes the example so that it's run by doctest. |
Member
|
@cdeil - thanks, looks good to me for merge. I'm just not sure if a doc fix like this should be back-ported to LTS. @astrofrog or @eteq? |
Member
|
@taldcroft - I would say yes, just in case. It's not much work to backport simple patches like this, so no harm. |
eteq
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fix mistake in ECSV reader docstring and make example testable
eteq
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fix mistake in ECSV reader docstring and make example testable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@taldcroft - Is the basic ECSV example from the Astropy docs broken again?
http://docs.astropy.org/en/latest/api/astropy.io.ascii.Ecsv.html
I thought we fixed it and I checked that it worked in #5263, but now I get an error again:
gives this error:
I think the problem now is that the column info has the key
typeinstead ofdatatype?Was there a change in the ECSV reader or was this example always broken?
It looks like this issue is also present in the original APE, which I guess is still the reference to look at for ECSV
https://github.com/astropy/astropy-APEs/blame/master/APE6.rst#L319