Repository navigation
Tweaks from 5273 - #5436
Tweaks from 5273#5436
Conversation
StuartLittlefair
left a comment
StuartLittlefair
left a comment
There was a problem hiding this comment.
Looks great to me. We've moved prepare_earth_position_vel back and forth a few times, but I don't have a strong opinion either way.
|
hah, well, I think it really is of general use so it's probably good to be in utils (where someone might conceivably go looking if they're trying to figure out how to do that...) |
|
Yes, that is funny, as I asked @StuartLittlefair to move that routine out of |
|
Oh, I missed that. Well, I guess this is my vote, then ;) |
pllim
added
time
coordinates
Affects-dev
| only the positions, one should use ``get_body_barycentric``. [#5231] | ||
|
|
||
| - Transformations between coordinate systems can use the more accurate JPL | ||
| ephemerides. [#5273] |
There was a problem hiding this comment.
Astrobot is going to complain that #5436 is not listed... Also same with the other entry.
|
Good points, @pllim - hopefully astrobot will will like it now... Here goes! |
|
Yay! I didn't make @astrobot angry! |
|
It is funny how making |
This has a few minor changes from #5273 that I would have pointed out in a review, but I was too slow at reviewing it. Look good to you @StuartLittlefair ? (In particular, note that I changed these to "new feature" and v1.3 in the changelog, as it's definitely a new feature.)