Fix a bug with empty value at end of tab-delimited table on windows #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me! 👍 |
eteq
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fix a bug with empty value at end of tab-delimited table on windows
eteq
pushed a commit
that referenced
this pull request
Dec 21, 2016
Fix a bug with empty value at end of tab-delimited table on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A table like below (spaces added for clarity) was failing in the fast tab reader on Windows. This is related to the
\r\nline endings:This PR changes the way the fast reader handles Windows CRLF line endings by effectively replacing the
\rwith\non-the-fly in the tokenizer (but not in the code that does line counting). This is safe because an empty line is just ignored.This change had a beneficial side effect of simplifying code, reducing states etc.
@mdmueller ?