Repository navigation
Fits header normalize keywords - #5321
Conversation
|
I think this needs a change log entry under "bug fix". Marking it for 1.2.2 but feel free to change if incorrect. |
| del header['abcdefghij'] | ||
| header.insert(2, ('abcdefghij', 10)) | ||
| del header[2] | ||
| assert header.keys()[2]=='abcdefg'.upper() |
There was a problem hiding this comment.
That's the reason why the tests failed. In python3 the keys() return a generator. You could cast it to a list:
assert list(header.keys())[2]=='abcdefg'.upper()
There was a problem hiding this comment.
Another possibility used in other tests is assert header.cards[2].keyword == 'abcdefg'.upper().
It avoids to generate the list of keys.
|
@crawfordsm - could you rebase this? |
|
@crawfordsm - actually do you mind if I try and rebase and force push to this branch? I want to see if the 'allow edits from maintainers' option from GitHub now allows me to rebase branches for other people. |
|
So, noone is doing the rebase? 😄 |
|
Sorry, I only saw this now. I'll try to do the rebase this evening. |
|
Or if @astrofrog wants to rebase that, it is fine with me. Sorry, I missed the messages on this. |
|
@crawfordsm - feel free to go ahead with rebasing :) |
|
still needs the rebase 😄 |
5236541 to
401286f
Compare
|
Okay, rebased |
| @@ -370,6 +370,8 @@ Bug Fixes | |||
| always read as float64. [#5362] | |||
|
|
|||
| - Fixed memoryleak when using the compression module. [#5399, #5464] | |||
|
Any reason for the tests to run? I think they are triggered by the non-standard commit. Btw: that commit looks weird. 😄 |
|
No I didn't mean for the tests to run due to a typo. Otherwise, it is just adding a space |
|
Since it is approved, merging. |
Update how a number of tasks work in fits.io.hdu.header such that they are more consistent in how it treats HIERARCH keywords including how they are inserted and removed. For more details see #5313.
Closes #5313