Skip to content

Representation arithmetic #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhvk merged 12 commits into from
Oct 28, 2016
Merged

Representation arithmetic #5301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a53ee20
Add arithmetic operations to representations.
mhvk Sep 1, 2016
77d0bdf
Clarification/simplificication following comments from Michael Seifert.
mhvk Sep 3, 2016
3976553
Add __neg__ and __pos__ methods.
mhvk Sep 5, 2016
3b516a9
Remove __eq__ as it is too liable to give false negatives.
mhvk Sep 8, 2016
ce292f7
Simplifications and clarifications following Tom Aldcroft's comments.
mhvk Oct 3, 2016
ba5c155
Add comment about choice of values for tests. [skip ci]
mhvk Oct 12, 2016
9dd4707
Add tests for __pos__ and __neg__.
mhvk Oct 18, 2016
bcd0a6b
Ensure tests also cover exceptions.
mhvk Oct 18, 2016
3261f90
Change __abs__ to norm, and clarify docstrings, following Erik Toller…
mhvk Oct 27, 2016
5935a8d
Add documentation about vector arithmetic.
mhvk Oct 12, 2016
2ee96e2
Changelog entry.
mhvk Sep 2, 2016
4df4d7e
Post-rebase fixups.
mhvk Oct 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,19 @@ New Features
- Transformations between coordinate systems can use the more accurate JPL
ephemerides. [#5273, #5436]

- Arithmetic on representations, such as addition of two representations,

@taldcroft taldcroft Oct 1, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding wording that this treats representation points as vectors in cartesian space. Then everything that follows is indeed "obvious".

@mhvk mhvk Oct 3, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Done.

multiplication with a ``Quantity``, or calculating the norm via ``abs``,
has now become possible. Furthermore, there are new methods ``mean``,
``sum``, ``dot``, and ``cross``. For all these, the representations are
treated as vectors in cartesian space (temporarily converting to
``CartesianRepresentation`` if necessary). [#5301]
has now become possible. Furthermore, there are news methods ``mean``,

@taldcroft taldcroft Oct 1, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo news.

@mhvk mhvk Oct 3, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done

``sum``, ``dot``, and ``cross`` with obvious meaning. [#5301]
multiplication with a ``Quantity`` has now become possible. Furthermore,
there are new methods ``norm``, ``mean``, ``sum``, ``dot``, and ``cross``.
In all operations, the representations are treated as vectors. They are
temporarily converted to ``CartesianRepresentation`` if necessary. [#5301]

- ``astropy.cosmology``

- ``astropy.io.ascii``
Expand Down
Loading