Skip to content

Fix precision and width attributes to match the VOTable spec. #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdboom merged 2 commits into from
Dec 4, 2012
Merged

Fix precision and width attributes to match the VOTable spec. #527

mdboom merged 2 commits into from
Dec 4, 2012

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented Dec 4, 2012

This is in response to something found in #526, though it doesn't necessarily fix that problem.

This makes the precision and width attributes behave (I think) correctly according to the spec.

Note that there are two forms of the precision attribute in VOTable:

the precision attribute is meant to express the number of significant digits,
 either as a number of decimal places (e.g. precision="F2" or 
equivalently precision="2" to express 2 significant figures after the 
decimal point), or as a number of significant figures (e.g. precision="E5" 
indicates a relative precision of 10-5).

@astrofrog
Copy link
Member

astrofrog commented Dec 4, 2012

This works nicely now - thanks for the fix! Feel free to merge once ready.

mdboom added a commit that referenced this pull request Dec 4, 2012
@mdboom
Merge pull request #527 from mdboom/votable/precision
24e28b2 
Fix precision and width attributes to match the VOTable spec.
@mdboom mdboom merged commit 24e28b2 into astropy:master Dec 4, 2012
@mdboom mdboom mentioned this pull request Dec 6, 2012
Merged
@embray
Copy link
Member

embray commented Apr 2, 2013

This somehow never got a milestone attached, but it was merged in well before the 0.2 release.

@taldcroft taldcroft mentioned this pull request May 13, 2013
Closed
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
@mdboom
Merge pull request astropy#527 from mdboom/votable/precision
3598ccb 
Fix precision and width attributes to match the VOTable spec.
@mdboom mdboom deleted the votable/precision branch May 21, 2014 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mdboom @astrofrog @embray