Repository navigation
Time initializer enhancements - #523
Merged
Merged
Conversation
Member
|
@eteq - thanks, good idea. The new exception error messages are much better. I just issued a PR on your time-init-additions branch with a different approach for initializing with a Time object. |
Modified approach for time init additions
Member
|
+1 |
Member
Author
|
Ok, I'll make sure the tests pass and if all is fine I'll go ahead and merge. |
keflavich
pushed a commit
to keflavich/astropy
that referenced
this pull request
Oct 9, 2013
Time initializer enhancements
jeffjennings
pushed a commit
to jeffjennings/astropy
that referenced
this pull request
Jul 2, 2025
Roles: Remove package template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a couple relatively minor changes to the
astropy.time.Timeinitializer:@taldcroft, of course, should take a look at this before it gets merged (especially in the first commit, you may want to make sure I'm understanding what those messages meant correctly).