Repository navigation
TST: test LombScargle for integer inputs - #4965
Merged
Merged
Conversation
Contributor
Author
|
This might fail on 32-bit machines without the fix from #4950. It depends on the particular architectures that the CI systems use. |
Member
|
@jakevdp - Afaik we don't have any 32bit CI, but usually do 32bit test runs for the release candidates. |
Contributor
Author
|
Tests are failing due to integer casting. I'm going to rebase on master now that #4950 is merged. |
Member
|
I cancelled the failing Travis build. FYI. |
pllim
added
the
Affects-dev
jakevdp
force-pushed
the
lombscargle-int-input
branch
from
May 20, 2016 19:16
8e17a69 to
8e100ea
Compare
Member
|
Marking this as 1.2 since it is closely related to the other PR also marked for 1.2. |
Contributor
Author
|
Tests pass with the #4950 fix! |
Contributor
|
Looks good. @astrofrog - I don't want to make work for you, but it seems this would also be a good addition to 1.2 -- not as much a bug-fix, but rather as a bug-preventer! If you agree, feel free to merge. |
Member
|
👍 |
astrofrog
added a commit
that referenced
this pull request
May 30, 2016
TST: test LombScargle for integer inputs
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. discussion at #4950