Repository navigation
Add dev requirements file - #4916
Conversation
| scipy | ||
| pandas | ||
| h5py | ||
| bs4 |
There was a problem hiding this comment.
I think you want beautifulsoup4 here instead. bs4 gets you to here: https://pypi.python.org/pypi/bs4/
|
If we go ahead with this, I would suggest renaming the files to |
|
Good point @astrofrog - done. No opinions have been issued thus far as to whether we should do this at all.. @mwcraig @astrofrog, @taldcroft @bsipocz, @adrn, do any of you have opinions? FWIW, I think this is useful to have, and might make the "astropy-dev" conda install a bit easier to implement...? Also note that this no longer requires #4915, as it turns out there's a different way to convince travis to do the right thing there. So this is now purely "information". |
|
Not strong feelings...as noted here, I have created an astropy-dev conda environment to kick the tires on, installable with I've opened an issue (https://github.com/conda/conda-env/issues/243) on the |
|
No strong feelings either -- I think it could be useful, so, sure? |
|
Just to be clear, the possible downside of this is that if the |
|
Sure, but that will always be the case. Right now what complicates generating the conda environment a little bit are two things:
The first one will get easier as packages continue to be added to conda-forge; once all of the dependencies are in there we can auto-generate the environment. |
| ... | ||
|
|
||
| In the astropy core package, such optional dependencies should be recorded in | ||
| the ``dev-pip-requirements`` file in the root of the repository. |
|
Along the lines that @mwcraig mentioned, what seems slightly confusing about this approach is that many of the requirements are currently conda-installable. It isn't quite clear to me how a typical (or new) developer should actually use these requirement files. The changes to the docs in this PR just describe how to maintain the files but not how to use them. Overall I'm definitely 👍 on capturing these requirements somehow and making it easier for developers to set up their environment. |
|
@taldcroft @mwcraig - I agree that what I would likely do is look at the list, try to Should I update the PR to include that as a recommendation? My thinking of the scope of this PR is not to update the installation instructions (for dev or otherwise), but rather to just establish the authoritative place for this information. It could be in some other format if someone has a preference, but this seems convenient if only because |
|
This looks good to me, too. Also the dev docs contain detailed information how to set up virtualenvs using pip only, and if anyone prefers that over conda (like me), then having the |
|
@eteq -- agree that this PR is limited in scope, so just adding this without adding anything about conda is fine. |
|
👍 |
1 similar comment
|
👍 |
|
looks like it's got the A-OK, so will merge |
|
@eteq - thanks for merging this! However, I noticed the following issue with this pull request:
Would it be possible to fix this? Thanks! This is an experimental bot being written by @astrofrog - let me know if the message above is incorrect! |
Add developer pip-style requirements files
(Note: This PR should be merged after #4915, as it's build on top of it.)
In #4915 I discussed a possible need for a pip requirements file for the docs build. It occurred to me that this might also be a good solution for how to list the "developer" requirements (i.e. all the packages that are used anywhere as optional or build-required dependencies). So this PR adds just such a file.
This is also partly inspired by @mwcraig and @bsipocz's discussion about a conda container package along the lines of
astropy-dev. Would it make sense to add this and then have that just auto-build from this list of package names?