-
-
Notifications
You must be signed in to change notification settings - Fork 2k
utils.data fixes #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils.data fixes #481
Conversation
…associated docstring fix
astropy/utils/data.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: download (no s)
|
Apart from my comments above, this looks fine to me. However, maybe it would be worth adding |
|
@astrofrog - thanks for mentioning As for Assuming the tests pass, I think this is good to go, now. |
|
Looks good to me! Tests are passing, feel free to merge. |
|
@pllim - yeah, the |
|
@eteq , thanks for the info. I tried again after deleting ~/.astropy and after I did |
|
@astrofrog - it appears |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting based on the failing Travis results when turning on --remote-data (#491).
googlepage.read().decode('utf-8').find('oogle</title>') > -1
Travis apparently has a default encoding of ascii, so it can't decode the utf-8-encoded Google homepage.
utils.data fixes
Update ccdproc maintainer
This is a few fixes in
utils.dataspurred by #480. This should now letdata.clear_data_cachecache work correctly (although note that it has been renameddata.clear_download_cache).@pllim, can you confirm that this fixes #480 for you? (although again not that it should now be modified to be
clear_download_cacheinstead ofclear_data_cache.@astrofrog, you might want to look at this, as it deals with some of the changes from #425. Mostly cosmetic, in that it changes "data" to "download" to reflect the broader scope of the cache now. But there was one place where it seemed the cache option was not going through (incorrectly, I believe).