Drop support for Numpy 1.6 #4784
Conversation
|
| 1.2 (unreleased) | ||
| ---------------- | ||
|
|
||
| General |
There was a problem hiding this comment.
Not sure about new section. Maybe move this under "API change"?
There was a problem hiding this comment.
Oh, never mind. I see there is a precedent. Please ignore my comment above.
There was a problem hiding this comment.
I followed the example of the 1.0 release, but I can change.
|
@astrofrog needs to clarify about supporting "the last 4 Numpy versions". Does that mean the "stable" plus 4 older ones (which would include 1.7). Or just 4 total, including stable? |
|
@pllim - what I said wasn't policy, I just meant that supporting 1.11, 1.10, 1.9, and 1.8 should probably be enough (but it's a personal opinion) |
|
@astrofrog , from your bar chart, eliminating both 1.6 and 1.7 would exclude 10% of the users that the chart represented in Oct 2015, which is only 6 months ago. It is not huge but also not negligible. Something to think about. |
|
@pllim - The survey was done over a year ago not in Oct! |
|
Oh, okay. I got the timestamp from the GitHub comment. Thanks for clarifying, @bsipocz . But still, some users are not known for constantly upgrading their software versions (not tech bashing, but maybe a little). |
|
But then they are not upgrading their astropy either (and are stuck with v0.2) ;) |
|
@saimn , 👍 for deprecation warning, but I think that should be a separate PR tagged to a different milestone. |
|
@saimn - for now, let's keep Numpy 1.7 since you didn't remove any of that compatibility code (i.e. |
|
@astrofrog - Oops ! You're right, I got confused by the presence of both |
Compatibility code for Numpy 1.7 wasn't removed, so keep it for now.
|
Thanks! Let's now wait a couple of days to see if there are any objections. |
|
Good to go ? |
|
No strong objections from |
|
Just found |
|
Last chance for objections or forever hold your peace! |
|
Up ! Let's go ? |
CHANGES.rst
Outdated
| General | ||
| ^^^^^^^ | ||
|
|
||
| Astropy now requires a Numpy 1.7.0 or later. |
There was a problem hiding this comment.
@saimn - can you remove a (just 'requires Numpy') - when you commit, add [ci skip] in the commit message since we don't need to re-run the CI
|
Thanks @saimn! |
|
Thanks ! |
4 participants
Following #4225
and 1.7. (There are still a few things that could possibly be removed, but I wasn't sure)