Repository navigation
Conversation
rirze
changed the title
Member
|
@rirze - you should just be able to add tests like: |
| t.add_index('a') | ||
| original_key = t.primary_key | ||
|
|
||
| assert original_key is not None |
Member
There was a problem hiding this comment.
Might as well test that original_key == ('a',).
Member
Member
|
@rirze - could you rebase this on the latest version of astropy? (there are conflicts at the moment) |
Member
|
I just restarted one test that was failing for unrelated reasons. This should be good to merge assuming that passes this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #4672.
In the issue, running an example from the astropy docs for Table indexing would run into an error. The error was a missing
primary_keyfor the table in question. The error arises when a new Table is made from an existing one, either by slicing or reference, but theprimary_keyattribute is not transferred to the new Table. This PR fixes that.I added one test for this case, but I couldn't figure out a way to test for
.locas @taldcroft suggested in the issue. I'm actually not that familiar with Tables or with writing test cases (this is my first attempt to do so), so any feedback would be appreciated.