Repository navigation
Conversation
…unsigned-int columns.
…hat always nice? This handling of unsigned ints already happens in FITS_rec.from_columns, by way of Column._convert_to_valid_data_type.
embray
force-pushed
the
fix-table-uint-update
branch
from
March 18, 2016 09:13
62307c1 to
5eb6e55
Compare
Member
Author
|
Rebased on latest master--apparently I was working off a relatively old master. Note the CI for this PR will still fail for now as I've only added the regression test but not the fix yet. |
Member
|
Incomplete and unlikely to be worked on anymore. Original issue #3921 still open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress fix to the issue reported on Stack Overflow here: http://stackoverflow.com/questions/35921060/updating-pyfits-bin-table-data#35921060
I believe this might also be the same issue as #3921, but as the use case in that issue is slightly different I'm not 100% sure (nevertheless it still relates to updating unsigned int data in a table).
Right now this PR only contains the regression test, and some preliminary code cleanup that I realized was possible. I haven't had time to complete the fix yet. But if someone else wants to look into it I can point you in the right direction.