Skip to content

Updated Cone Search URLs for VizieR services due to external changes - #4699

Merged
pllim merged 2 commits into
astropy:masterfrom
pllim:conesearch-vizier-update
Mar 17, 2016
Merged

pllim merged 2 commits into
astropy:masterfrom
pllim:conesearch-vizier-update

Conversation

@pllim

@pllim pllim commented Mar 15, 2016

Copy link
Copy Markdown
Member

Updated Cone Search URLs for VizieR services due to external changes. Updated URL unescaper to deal with the new URLs. Fixed a minor bug in XML validator to handle division by zero. Updated Cone Search documentation with correct examples.

Who knew one URL change can result in such a mess.

… Updated URL unescaper to deal with the new URLs. Fixed a minor bug in XML validator to handle division by zero. Updated Cone Search documentation with correct examples.
@pllim

pllim commented Mar 16, 2016

Copy link
Copy Markdown
Member Author

Any objection to merge this by 5PM EST on Mar 17? If I don't hear anything, I'll merge it then.

@pllim

pllim commented Mar 17, 2016

Copy link
Copy Markdown
Member Author

No objections, so merging.

pllim added a commit that referenced this pull request Mar 17, 2016
Updated Cone Search URLs for VizieR services due to external changes
@pllim
pllim merged commit 95b576e into astropy:master Mar 17, 2016
@pllim pllim added this to the v1.2.0 milestone Mar 17, 2016
@pllim pllim added the Affects-dev PRs and issues that do not impact an existing Astropy release label Mar 17, 2016
@pllim
pllim deleted the conesearch-vizier-update branch March 17, 2016 20:21
pllim added a commit to pllim/astropy that referenced this pull request Apr 4, 2016
… result (side effect of astropy#4699) when it is not supposed to. Not sure why I did not catch this earlier.
@astrofrog astrofrog removed the Affects-dev PRs and issues that do not impact an existing Astropy release label May 12, 2016
@astrofrog astrofrog modified the milestones: v1.0.10, v1.2.0 Jun 9, 2016
@astrofrog

Copy link
Copy Markdown
Member

I've decided to backport this to v1.0.10 since it fixes issues with the remote tests there too

astrofrog pushed a commit that referenced this pull request Jun 9, 2016
Updated Cone Search URLs for VizieR services due to external changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants