Repository navigation
Added AttributeError when trying to set mask on non-masked table - #4637
Merged
Merged
Conversation
Contributor
Author
|
ping @taldcroft |
|
|
||
| def __setattr__(self, item, value): | ||
| if not isinstance(self, MaskedColumn) and item == "mask": | ||
| raise AttributeError("Cannot set mask value to a Column in non-masked Table") |
Member
There was a problem hiding this comment.
Use lower case to start the error message, i.e. cannot set ... We are not consistent about this but new code should follow that convention.
Member
|
@mvnnn - please add an entry to the new features for 1.2 and address my minor comments, then this will be good. Thanks! |
Member
|
(I meant new features in CHANGES.rst). |
mvnnn
force-pushed
the
bugfix-for-issue-3505
branch
from
February 29, 2016 16:11
1c690db to
ca81b1b
Compare
mvnnn
force-pushed
the
bugfix-for-issue-3505
branch
from
February 29, 2016 16:15
ca81b1b to
7c31248
Compare
Member
|
@mvnnn - it is not necessary or desirable to always squash commits into one. By doing so that makes it more difficult to see that you made the requested changes. I just restarted a failed build test and hopefully that will give you a CI pass. |
taldcroft
added a commit
that referenced
this pull request
Mar 1, 2016
Added AttributeError when trying to set mask on non-masked table
Member
|
Thanks @mvnnn ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3505