Repository navigation
Remove gzip compatibility layer since we now no longer support Python 2.6 - #4464
Merged
Merged
Conversation
astrofrog
force-pushed
the
remove-gzip-compat
branch
2 times, most recently
from
January 10, 2016 16:44
e6318a3 to
a8eb8cc
Compare
astrofrog
force-pushed
the
remove-gzip-compat
branch
from
January 11, 2016 11:16
a8eb8cc to
d35602c
Compare
Member
Author
|
@embray - can you review this since it makes some changes in astropy.io.fits? |
Member
|
Looks good to me. I would ask the same question again about making our compat gzip module raise an exception and make sure tests pass. One question also about |
Member
Author
|
@taldcroft - I did check that no test failures occurred if I raise an exception. I'll clean up the list of modules in |
astrofrog
force-pushed
the
remove-gzip-compat
branch
2 times, most recently
from
January 12, 2016 15:33
1b38980 to
0f82dc6
Compare
Member
There was a problem hiding this comment.
This needs to be indented 2 spaces.
Member
|
Much better.... |
astrofrog
force-pushed
the
remove-gzip-compat
branch
from
January 13, 2016 20:07
0f82dc6 to
d24e718
Compare
Member
Author
|
@embray - done. Ready to merge? :) |
embray
added a commit
that referenced
this pull request
Jan 14, 2016
Remove gzip compatibility layer since we now no longer support Python 2.6
saimn
added a commit
to saimn/astropy
that referenced
this pull request
Jun 6, 2017
Note these were only issuing a warning before importing the stdlib modules. Follows astropy#4462 astropy#4463 astropy#4464, and similar to astropy#5975 and astropy#6157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.