Skip to content

Remove gzip compatibility layer since we now no longer support Python 2.6 - #4464

Merged
embray merged 7 commits into
astropy:masterfrom
astrofrog:remove-gzip-compat
Jan 14, 2016
Merged

embray merged 7 commits into
astropy:masterfrom
astrofrog:remove-gzip-compat

Conversation

@astrofrog

Copy link
Copy Markdown
Member

No description provided.

@astrofrog astrofrog added this to the v1.2.0 milestone Jan 10, 2016
@astrofrog
astrofrog force-pushed the remove-gzip-compat branch 2 times, most recently from e6318a3 to a8eb8cc Compare January 10, 2016 16:44
@astrofrog

Copy link
Copy Markdown
Member Author

@embray - can you review this since it makes some changes in astropy.io.fits?

@taldcroft

Copy link
Copy Markdown
Member

Looks good to me. I would ask the same question again about making our compat gzip module raise an exception and make sure tests pass.

One question also about astropy/tests/tests/test_imports.py. In your branch this still has references to the removed modules. Is that intended?

# Compatibility subpackages that should only be used on Python 2
_py2_packages = set([
    'astropy.extern.configobj_py2',
    'astropy.utils.compat._fractions_py2',
    'astropy.utils.compat._gzip_py2',
    'astropy.utils.compat._odict_py2',
    'astropy.utils.compat._subprocess_py2'
])

# Same but for Python 3
_py3_packages = set([
    'astropy.extern.configobj_py3',
    'astropy.utils.compat._gzip_py3'
])

@astrofrog

Copy link
Copy Markdown
Member Author

@taldcroft - I did check that no test failures occurred if I raise an exception. I'll clean up the list of modules in test_imports - good catch (but not critical)

Comment thread CHANGES.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be indented 2 spaces.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@embray

embray commented Jan 12, 2016

Copy link
Copy Markdown
Member

Much better....

@astrofrog

Copy link
Copy Markdown
Member Author

@embray - done. Ready to merge? :)

embray added a commit that referenced this pull request Jan 14, 2016
Remove gzip compatibility layer since we now no longer support Python 2.6
@embray
embray merged commit 2c75d0e into astropy:master Jan 14, 2016
@astrofrog
astrofrog deleted the remove-gzip-compat branch July 5, 2016 15:52
saimn added a commit to saimn/astropy that referenced this pull request Jun 6, 2017
Note these were only issuing a warning before importing the stdlib
modules. Follows astropy#4462 astropy#4463 astropy#4464, and similar to astropy#5975 and astropy#6157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants