Skip to content

Update AppVeyor configuration to drop Python 2.6 support - #4450

Merged
astrofrog merged 5 commits into
astropy:masterfrom
astrofrog:update-appveyor-versions
Jan 9, 2016
Merged

astrofrog merged 5 commits into
astropy:masterfrom
astrofrog:update-appveyor-versions

Conversation

@astrofrog

Copy link
Copy Markdown
Member

Also, always test against the latest stable Numpy version. This is the complementary PR to #4225.

cc @eteq @bsipocz

@astrofrog astrofrog added this to the v1.2.0 milestone Jan 7, 2016
@bsipocz

bsipocz commented Jan 7, 2016

Copy link
Copy Markdown
Member

👍
What about testing against 3.5 {rather than}/{and} 3.4?

@embray

embray commented Jan 7, 2016

Copy link
Copy Markdown
Member

+1 for testing Python 3.5.

@mhvk

mhvk commented Jan 7, 2016

Copy link
Copy Markdown
Contributor

Agreed, might as well test python 3.5

@astrofrog

Copy link
Copy Markdown
Member Author

I've added Python 3.5, but should I remove 3.4? It looks like it takes 10 minutes per configuration, so it's now going to take around 30 minutes per build. Maybe that's ok? (I've noticed appveyor finishing before Travis these days)

@mhvk

mhvk commented Jan 8, 2016

Copy link
Copy Markdown
Contributor

@astrofrog - I would remove 3.4; we're testing it on linux, so it really should be OK, and even if it doesn't save time, it does leave resources for others (and saves some little bit of power).

@astrofrog

Copy link
Copy Markdown
Member Author

@embray - it looks like there are some FITS-related failures on Windows with Python 3.5 - any idea what those are due to?

@embray

embray commented Jan 8, 2016

Copy link
Copy Markdown
Member

@astrofrog I believe all of them are due to #4342

@astrofrog
astrofrog force-pushed the update-appveyor-versions branch from 2ca7c27 to 0a760e8 Compare January 8, 2016 19:29
@astrofrog
astrofrog force-pushed the update-appveyor-versions branch from 9ddf423 to cd1ec27 Compare January 8, 2016 19:35
@astrofrog

Copy link
Copy Markdown
Member Author

@embray @mhvk @bsipocz - I've left 3.5 in as an allowed failure. Since this runs faster than Travis, I've left in 3.4 otherwise we have no indicator that 3.x is failing. Once 3.5 is unmarked as an allowed failure, we can remove 3.4.

@embray

embray commented Jan 8, 2016

Copy link
Copy Markdown
Member

Maybe make a note in #4342 that that should be done as part of a fix for that issue.

@astrofrog

Copy link
Copy Markdown
Member Author

I'll go ahead and merge this, and I've made a note in #4342

astrofrog added a commit that referenced this pull request Jan 9, 2016
Update AppVeyor configuration to drop Python 2.6 support
@astrofrog
astrofrog merged commit e30e8ca into astropy:master Jan 9, 2016
@astrofrog
astrofrog deleted the update-appveyor-versions branch July 5, 2016 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants