Repository navigation
Remove backward-compatibility hacks for old configuration system - #4446
Conversation
There was a problem hiding this comment.
This is either incorrect or confusing. This conf is most likely the one imported in Line 20, which is from io.votable, not utils.data. Also at some other places in the same module, conf is overwritten by from .. import conf. I think the conf import lines need some clean up.
There was a problem hiding this comment.
Yes, I've fixed this in an upcoming commit
|
Haven't looked at the code changes yet but 👍 from me in principle. |
|
I sent a message to astropy-dev about this and gave a deadline of Monday to merge this if all tests pass. |
|
@astrofrog - This (and the other PRs opened today) will close #3500, too. |
|
The tests are passing, so this is now ready for review. |
|
PRs that remove an order of magnitude more code than they add are the best. Looks good to me. |
|
👍 from me! |
99791b7 to
c601ea1
Compare
|
Had to rebase due to a changelog entry conflict, but will then merge. |
|
There have been no objections raised on astropy-dev. Merging! |
Remove backward-compatibility hacks for old configuration system
|
I like to remove "Ready-for-final-review" after it's been closed. Though it mostly doesn't matter. |
…aliases Remove backward-compatibility hacks for old configuration system
…aliases Remove backward-compatibility hacks for old configuration system
This addresses #2767
The package template didn't actually use the old configuration system (it didn't have any example configuration items at all). So astropy/package-template#57 doesn't actually have to be merged yet (or at all), so we can focus on finishing up this PR first, and then we can consider separately whether to include an example in the package template.