Repository navigation
Workaround to bug in #4171 - #4393
Conversation
embray
added
Bug
Affects-release
zzz 💤 analytic_functions
|
Passed on Appveyor \o/ |
|
Come to think of it, a simpler fix for this might be to just provide an alternative implementation of |
|
FWIW this is no longer an issue in python 3.5/numpy 1.10, though it is in python 2.7/numpy 1.10. Best guess is that it has been fixed on the MSVC side since the compiler changed in 3.5 |
|
@mwcraig That's probably right--that the only reason it's fixed for Python 3.5 is the newer MSVC version it was built with. |
embray
added
the
Affects-dev
|
Milestone set to v1.1.0 right now. @eteq @astrofrog Unless you disagree with merging this for whatever reason. Otherwise the milestone can be changed to v1.1.1, but "Affects-dev" will then have to be changed to "Affects-release" as well. |
eteq
added
Affects-release
and removed
Affects-dev
|
Sorry, the gears had already been turning on v1.1 release (which is on PyPI now and will be announced first thing monday), so this will have to go to 1.1.1 |
|
Oh, and given that I guess it should get a changelog entry for 1.1.1, @embray (you'll probably need to rebase to do that because the section was just added in master) |
|
That's fine. |
…ings down on platforms that don't have this bug, but will add a little overhead otherwise.
b0919d3 to
2986cb2
Compare
Adds workaround for buggy implementations of expm1--shouldn't slow things down on platforms that don't have this bug, but will add a little overhead otherwise.
This attempts to add a workaround to the issue reported in #4171 rather than outright disable the tests. This puts a workaround in the function implementations so that they still return the correct results (at the cost of a little extra overhead on affected platforms).
This is also a possible alternative to #4275.