Repository navigation
Updated bundled py.test to 2.8.3 - #4349
Conversation
|
Also, this is not 1.1-critical so should not be backported and should not hold up the final release. |
|
thanks @astrofrog, i'll try this out to see how much of those extra 25 fails go away :) |
|
Well whatever the case this should be mentioned in the changelog for some release. |
|
(Or more specifically, should be explicitly targetted for a release.) |
|
@astrofrog - When I run the full test suite twice with this PR, I still see 29 fails and 2 errors. Full log here: https://gist.github.com/bsipocz/0f37ec40b7c929044fee |
|
Yeah, this is very much a work in progress - it actually creates more failures than it fixes. I don't have time to investigate that this week, so if someone would like to take this over, please feel free to (but this is not 1.1 critical and there is no actual bug in the astropy code) |
93324c2 to
d3393a2
Compare
|
@astrofrog - Nope, it still fails even with your minimal example above (with the same failures). |
a15992e to
2d13552
Compare
0268bf7 to
c97e958
Compare
|
There are still some failures that occur when the tests are run twice, but I've opened a separate issue for those: #4444 - in the mean time, it would be good to merge this PR once it passes, since it contains some fixes that are needed if testing affiliated packages with a recent version of |
… run properly again if run multiple times
…ytest, stdout is replaced by ChannelFileWrite which doesn’t have an encoding attribute.
c97e958 to
e3cd103
Compare
|
The remaining failures are due to the fact that if you run the tests twice, the tests that ensure the deprecation warnings are raised (e.g. |
|
Agreed that it makes sense to merge this now. I have a thought about the no-warnings-second-time problem that I'm going to investigate, but if I can't make it work I'll make an issue so that we can investigate it later. There's some question here about backporting... My feeling is that this should only get backported if it actually fixes failures in the 1.0.x or 1.1.x - am I understanding right from the above that this fixes failures from double-invocation, but that it still runs fine on the standard |
This updates the bundled py.test to 2.8.3 and fixes the issue reported by @bsipocz: #3499
The easiest way to reproduce that original issue is:
However, there are still some other (unrelated) errors in the second run:
@embray @nden - it looks like there must be some internal state that gets preserved between runs?
Note also that
--genscripthas been deprecated in py.test:pytest-dev/pytest#884
So we may want to consider actually removing the bundled version and simply requiring py.test to be installed in order to run the tests. We could always consider this to be the last upgrade of the bundled version, and next time something breaks and requires a more recent py.test, we can then remove it?