Table indexing with docstring fix for Windows #4202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
force-pushed
the
table-indexing-tla
branch
from
e41c645 to
f8790d1
Compare
Member
|
@taldcroft - looks good :) merge when ready! |
Contributor
|
Tests passed, so I'm merging. |
mhvk
added a commit
that referenced
this pull request
Sep 30, 2015
Table indexing with docstring fix for Windows
Member
Author
|
Thanks @mdmueller! 🎆 |
Member
|
🎊 |
This was referenced Sep 30, 2015
Contributor
|
And thanks @taldcroft for the docstring fix! |
Member
Author
|
The windows int32 default is a continual source of fun for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just #3915 but rebased to the latest master and with a fix for the docstring test fail on Windows.